Move LastBlockMonitor and NodeState out of node module#314
Merged
rustaceanrob merged 1 commit intomasterfrom Mar 28, 2025
Merged
Move LastBlockMonitor and NodeState out of node module#314rustaceanrob merged 1 commit intomasterfrom
LastBlockMonitor and NodeState out of node module#314rustaceanrob merged 1 commit intomasterfrom
Conversation
The `node` module is getting cluttered and these are self-contained structures. Doing a bit of a stretch in encapsulation here, but I think since the time we see the last block is implicit to the node network connections, I would like it to be in `network`. The `NodeState` is currently very primitive, so I think `lib` is suitable. If `NodeState` starts to contain data or methods then it might belong in `node` again.
nyonson
approved these changes
Mar 28, 2025
|
|
||
| /// The state of the node with respect to connected peers. | ||
| #[derive(Debug, Clone, Copy)] | ||
| pub enum NodeState { |
Collaborator
There was a problem hiding this comment.
This is a personal preference so not holding up this patch, but to me NodeState is so specific to node, I would favor keeping it there so that there is clear ownership. Node defines its states. I think this is inline with my general preference to use lib.rs as a "table of contents" which holds very little definitions itself.
Collaborator
Author
There was a problem hiding this comment.
I understand that reasoning definitely. It is used as part of the Log message though. If it does gain function in the future, I think it should go back into node for sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nodemodule is getting cluttered and these are self-contained structures. Doing a bit of a stretch in encapsulation here, but I think since the time we see the last block is implicit to the node network connections, I would like it to be innetwork. TheNodeStateis currently very primitive, so I thinklibis suitable. IfNodeStatestarts to contain data or methods then it might belong innodeagain.