Remove ignore case when bitcoind is not ready#334
Merged
rustaceanrob merged 1 commit intomasterfrom Apr 17, 2025
Merged
Conversation
rustaceanrob
force-pushed
the
ci-ignore-4-17
branch
from
adf7e32 to
7e9dc04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing #322 I noticed that the
bitcoindintegration tests were not running. I had a short circuit case in each test that would skip over it ifbitcoindwas not available, but that was a relic of when I was runningbitcoindmanually. Removes that early return case to debug why the CI is not playing nice withcorepc