Queue mechanism to stop processing jobs

[ani2amigos]

No description provided.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
❌ -7.64% (target: -1.00%)	✅ 10.53%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (c8b28e7)	596	579	97.15%
Head commit (837afd9)	648 (+52)	580 (+1)	89.51% (-7.64%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#24)	57	6	10.53%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

[2amjsouza]

10 its a lot of to be set as default, you can change this to be 3

[2amjsouza]

@ani2amigos as we have a config file to deal with the envs and load them all at once, you can move this $_ENV['MAX_ATTEMPTS_DEFAULT'] there so we can easily have access to all env setup

[2amjsouza]

pheanstalk has a method to re-queue the job, the release as it was set.
set the algorithm to be like:

• if not finished, increase the attempt number;
• if not overtaking the number of attempts defined, use release method;
• if it's finished or reached the attempts limit, delete

[2amjsouza]

remove any comment from code not related to docs

[2amjsouza]

avoid using else when writing the algs, return query execute instead, them outside the if, the other case:

if($mailJob->getAttempt() > $_ENV['MAX_ATTEMPTS_DEFAULT']){
            $sqlText = 'DELETE FROM mail_queue WHERE id = :max_attempt;';
            $sql = sprintf($sqlText, $this->tableName);
            $query = $this->getConnection()->getInstance()->prepare($sql);
            $query->bindValue(':id', $mailJob->getId());

            return $query->execute();
        }

$sqlText = 'UPDATE `%s`
                SET `attempt`=:attempt, `state`=:state, `timeToSend`=:timeToSend, `sentTime`=:sentTime
                WHERE `id`=:id';

... rest of your code