Skip to content

Conversation

@bnlerner
Copy link

@bnlerner bnlerner commented May 4, 2025

Changes:

  • First is compiling using older version of linux/can which use frame.can_dlc vs the newer frame.len. Checks this by compiling using can_dlc then opts to use can_dlc in relevant functions like utilities and node if so (so backwards compatible with the change from can_dlc -> len)
  • Second is adding a more dynamic way to search for pybind11 when building the wheel as several problems seen during builds.
  • Third is completes the python c++ binding by adding a mypy .pyi file so type hints and type checking show up correctly.

@bnlerner bnlerner changed the title Brian/build issues Fixes build issues and adds mypy stubs May 4, 2025
@2b-t 2b-t linked an issue May 13, 2025 that may be closed by this pull request
@2b-t
Copy link
Owner

2b-t commented May 13, 2025

Hi Brian,
Sorry for the delay. I am currently in the process of relocating and do not have access to my actuator to test the pull request. I should be able to test it in a few days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Take pull requests for library build improvement?

2 participants