Skip to content

Hotfix for old patch files #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UmedMuzl merged 1 commit into from
Dec 30, 2025
Merged

Hotfix for old patch files #2965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions randomizer/Settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
from randomizer.Prices import CompleteVanillaPrices, RandomizePrices, VanillaPrices
from randomizer.SettingStrings import encrypt_settings_string_enum
from randomizer.ShuffleBosses import (
BossMapList,

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'BossMapList' may not be defined if module
randomizer.ShuffleBosses
Loading
is imported before module
randomizer.Settings
Loading
, as the
definition
Loading
of BossMapList occurs after the cyclic
import
Loading
of randomizer.Settings.
KRoolMaps,

Check failure

Code scanning / CodeQL

Module-level cyclic import Error

'KRoolMaps' may not be defined if module
randomizer.ShuffleBosses
Loading
is imported before module
randomizer.Settings
Loading
, as the
definition
Loading
of KRoolMaps occurs after the cyclic
import
Loading
of randomizer.Settings.
ShuffleBosses,
ShuffleBossKongs,
ShuffleKKOPhaseOrder,
Expand Down Expand Up @@ -1773,6 +1775,9 @@
Maps.CastleBoss,
]
)
# This guard is for backwards compatibility
if not self.bosses_selected:
self.bosses_selected = BossMapList.copy() + KRoolMaps.copy()
phases = [x for x in phases if x in self.bosses_selected]
possible_phases = phases.copy()
if self.krool_phase_order_rando:
Expand Down
Loading