Skip to content

Fix z-index for region selector#102

Merged
hkamran80 merged 1 commit into2factorauth:masterfrom
Hacksore:fix/dropdown-zindex
Mar 22, 2025
Merged

Fix z-index for region selector#102
hkamran80 merged 1 commit into2factorauth:masterfrom
Hacksore:fix/dropdown-zindex

Conversation

@Hacksore
Copy link
Contributor

@Hacksore Hacksore commented Mar 15, 2025

Fix the dropdown z-index so it'd renders on top of the sticky headers.

Before:
image

After:
image

Also had to regen the lock file because of npm/cli#4828 and missing optional dep for rollup and my architecture.

master ✔ $ npm run dev  

> 2fa.directory@6.0.0 dev
> vite

/Users/hacksore/code/2fa.directory/node_modules/rollup/dist/native.js:63
                throw new Error(
                      ^

Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both pac
kage-lock.json and node_modules directory.
    at requireWithFriendlyError (/Users/hacksore/code/2fa.directory/node_modules/rollup/dist/native.js:63:9)
    at Object.<anonymous> (/Users/hacksore/code/2fa.directory/node_modules/rollup/dist/native.js:72:76)
    at Module._compile (node:internal/modules/cjs/loader:1734:14)
    at Object..js (node:internal/modules/cjs/loader:1899:10)
    at Module.load (node:internal/modules/cjs/loader:1469:32)
    at Function._load (node:internal/modules/cjs/loader:1286:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
    at cjsLoader (node:internal/modules/esm/translators:315:5)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:207:7) {
  [cause]: Error: Cannot find module '@rollup/rollup-darwin-arm64'
  Require stack:
  - /Users/hacksore/code/2fa.directory/node_modules/rollup/dist/native.js
      at Function._resolveFilename (node:internal/modules/cjs/loader:1405:15)
      at defaultResolveImpl (node:internal/modules/cjs/loader:1061:19)
      at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1066:22)
      at Function._load (node:internal/modules/cjs/loader:1215:37)
      at TracingChannel.traceSync (node:diagnostics_channel:322:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
      at Module.require (node:internal/modules/cjs/loader:1491:12)
      at require (node:internal/modules/helpers:135:16)
      at requireWithFriendlyError (/Users/hacksore/code/2fa.directory/node_modules/rollup/dist/native.js:45:10)
      at Object.<anonymous> (/Users/hacksore/code/2fa.directory/node_modules/rollup/dist/native.js:72:76) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [
      '/Users/hacksore/code/2fa.directory/node_modules/rollup/dist/native.js'
    ]
  }
}

@Hacksore Hacksore marked this pull request as ready for review March 15, 2025 19:34
@hkamran80 hkamran80 added Code enhancement Enchancements to the website code UI change Enhancements to the user interface and removed Code enhancement Enchancements to the website code labels Mar 15, 2025
@hkamran80 hkamran80 merged commit 679d6b2 into 2factorauth:master Mar 22, 2025
1 check passed
@hkamran80
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI change Enhancements to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants