-
Notifications
You must be signed in to change notification settings - Fork 78
Put contents of repo image is built from into /srv/repo #6630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yuvipanda
wants to merge
1
commit into
2i2c-org:main
Choose a base branch
from
yuvipanda:repo2docker-extra
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default repo2docker puts the contents of the repo the image is built from in /home/jovyan. This is overwritten by persistent home directory storage when using a persistent hub, so users can not access it. The solution in repo2docker is to put the contents in a different place. We have been putting it `/srv/repo` as part of our user image template with repo2docker-action (https://github.com/2i2c-org/hub-user-image-template/blob/e0a2578e66825134accccbd34b36ca2802e29079/.github/workflows/build.yaml#L44). This PR puts out the same behavior for all our dynamic imagebuilding hubs. Ref 2i2c-org#5499
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deployments
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIG TODO
This should really only apply for dynamic imagebuilding hubs and not binderhubs we run. Update the config appropriately.
By default repo2docker puts the contents of the repo the image is built from in /home/jovyan. This is overwritten by persistent home directory storage when using a persistent hub, so users can not access it.
The solution in repo2docker is to put the contents in a different place. We have been putting it
/srv/repo
as part of our user image template with repo2docker-action(https://github.com/2i2c-org/hub-user-image-template/blob/e0a2578e66825134accccbd34b36ca2802e29079/.github/workflows/build.yaml#L44).
This PR puts out the same behavior for all our dynamic imagebuilding hubs.
Ref #5499