Skip to content

Allow all our hubs to delete non-empty dirs #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuvipanda wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −6
Open

Allow all our hubs to delete non-empty dirs #7405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2b3dc7
Allow all our hubs to delete non-empty dirs
yuvipanda Jan 14, 2026
4bec205
fix typo
GeorgianaElena Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions config/clusters/maap/common.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,6 @@ jupyterhub:

c.KubeSpawner.volumes["s3fs-volume"] = {"name": "s3fs-volume", "emptyDir": {}}
singleuser:
extraFiles:
jupyter_server_config.json:
data:
FileContentsManager:
# Allow deleting full directories
always_delete_dir: true
cloudMetadata:
blockWithIptables: false
defaultUrl: /lab
Expand Down
4 changes: 4 additions & 0 deletions helm-charts/basehub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,10 @@ jupyterhub:
# https://github.com/jupyterlab/jupyterlab/issues/11304#issuecomment-945466766
ContentsManager:
allow_hidden: true
# Allow deletion of directories with files in them, after a confirmation dialog
# https://github.com/NASA-IMPACT/veda-jupyterhub/issues/96
FileContentsManager:
always_delete_dir: true
# Stop putting RTC state db on NFS. Sqlite on NFS always ends in tears
# https://github.com/2i2c-org/infrastructure/issues/2245
SQLiteYStore:
Expand Down
Loading