Fix logistic filter conflicts during player setup #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on status This commit introduces a crucial check to ensure that logistics handling is only performed for players who are currently connected to the game. Specifically, the check `game.connected_players[player.index]` has been added during the player setup process. This prevents attempts to manipulate logistic slots for players who are no longer connected, thereby avoiding errors and conflicts that arise from operating on disconnected players. By enforcing this condition, we improve the stability and reliability of the mod's logistics functionality, particularly in multiplayer scenarios where player connections may change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #53 by adding a check for connected players when handling logistics during player setup. Specifically, I included a validation to ensure that only players currently connected to the game are processed for logistic slot assignments. This change aims to prevent conflicts with logistic filters when players are not actively in the game, enhancing the mod's stability in multiplayer scenarios.
Please review the changes and let me know if there are any additional adjustments needed. Thank you!