Merge pull request #1167 from 3DStreet/break-loop-when-found

Some optimizations in SceneGraph code

Author: kfarr

src/editor/components/scenegraph/Entity.js

@@ -25,10 +25,7 @@ export default class Entity extends React.Component {
 
   toggleVisibility = () => {
     const entity = this.props.entity;
-    const visible =
-      entity.tagName.toLowerCase() === 'a-scene'
-        ? entity.object3D.visible
-        : entity.getAttribute('visible');
+    const visible = entity.object3D.visible;
     AFRAME.INSPECTOR.execute('entityupdate', {
       entity,
       component: 'visible',
@@ -82,10 +79,7 @@ export default class Entity extends React.Component {
     }
 
     // Visibility button.
-    const visible =
-      tagName === 'a-scene'
-        ? entity.object3D.visible
-        : entity.getAttribute('visible');
+    const visible = entity.object3D.visible;
     const visibilityButton = (
       <i
         title="Toggle entity visibility"

src/editor/components/scenegraph/SceneGraph.js

@@ -114,6 +114,7 @@ export default class SceneGraph extends React.Component {
         });
         Events.emit('entityselect', entity);
         found = true;
+        break;
       }
     }