Attempt at allowing build element with no built items #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atardugno
commented
Mar 30, 2022
atardugno
commented
- Relaxing the requirement for a build element to have one or more items
- Fixed a couple of typos
- Making sure the requirements for the coordinate system to be mapped to the output device is limited the output coordinate system (as referenced in other parts of the specification)
- Attempt to convey the message that a 3MF model would be ultimately be manufactured but can be in an intermediate state which is still not fully defined (e.g. there's no item referencing the object resource yet)
…hat the coordinate system definitition applies only to the build items
alexgryson
reviewed
Mar 30, 2022
3MF Core Specification.md
Outdated
| @@ -308,12 +308,12 @@ The language of the contents of a 3MF Document (typically useful for content pro | |||
|
|
|||
| # Chapter 3. 3D Models | |||
|
|
|||
| The _model_, in this specification, refers to the object or objects to be created via 3D manufacturing processes as a single operation. It might include a single object, multiple homogenous objects, multiple heterogeneous objects, an object fully enclosed in another object, or multiple objects in an interlocked and inseparable _assembly_. | |||
| The _model_, in this specification, refers to the object or objects to be ultimately created via 3D manufacturing processes as a single operation. It might include a single object, multiple homogenous objects, multiple heterogeneous objects, an object fully enclosed in another object, or multiple objects in an interlocked and inseparable _assembly_. A 3MF Document can be in an intermediate state in which none of the defined objects is yet ready to be manufactured, in which case no actual output object is expected. | |||
There was a problem hiding this comment.
I don't think the "ultimately" is needed here, we are not changing the core intention of 3MF to be a manufacturing format so the end state of being created by 3D manufacturing is unchanged and since the intermediate state (from editors, simulators etc.) is a possibility but not a certainty we don't necessarily need to make the distinction.
alexgryson
reviewed
Mar 30, 2022
3MF Core Specification.md
Outdated
| @@ -437,8 +437,7 @@ Element **\<build>** | |||
|
|
|||
|  | |||
|
|
|||
| The \<build> element contains one or more items to manufacture as part of processing the job. A consumer MUST NOT output any 3D objects not referenced by an \<item> element. | |||
|
|
|||
| The \<build> element could either be empty, in case of a 3MF Document providing only design objects, or contain one or more items to produce as part of processing the job. A consumer MUST manufacture only 3D objects which are referenced by an \<item> element. Any unreferenced object can still be processed by an editing application, which could finalize their manufacturing by referencing them in corresponding \<item> elements. | |||
There was a problem hiding this comment.
I would make this:
"The <build> element contains zero or more <item> elements to manufacture as part of processing the job. A consumer MUST NOT manufacture any 3D objects not referenced by an <item> element. Any unreferenced object can still be consumed by an editing application, which could then reference them in corresponding <item> elements when they are ready for manufacture."
I think that wording makes it clear that we are supporting new cases without changing any existing workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.