Minor Fixes for Example Scenes #2374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the evaluation of example scenes, I encountered the following issues:
SurfaceExample
Failed with the message:
FileNotFoundError: [Errno 2] No such file or directory: 'downloads/b4905915eb51c77d.jpg'GraphExample and CoordinateSystemExample
Dots appeared in the wrong color (light instead of red).Proposed Changes
file_ops.py
Added a call to
guarantee_existence(folder)beforeurllib.request.urlretrieve.Documentation and Example Code
Replaced all occurrences of
Dot(color=RED)withDot(fill_color=RED)in the relevant example scenes.