Fix: remove pkg_resources usage (deprecated), use importlib.metadata #2389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, running
manimglon Python 3.13+ produces a warning:UserWarning: pkg_resources is deprecated as an API...
This happens because
manimlib/__init__.pyimportspkg_resourcesonly to retrieve the package version.Since
pkg_resourcesis deprecated and scheduled for removal after 2025-11-30, this will eventually break ManimGL.Proposed changes
pkg_resourcesinmanimlib/__init__.py.importlib.metadata, the recommended standard library API (Python ≥3.8).Test
Code:
Result:
No deprecation warning is shown, and the version is still correctly displayed.
Closes #2388