Fix StrokeArrow: preserve tip geometry for large angles #2392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
StrokeArrow
did not preserve the tip geometry correctly for certain arc angles.The arrow tips could disappear, distort, or scale incorrectly depending on the arc length.
Proposed changes
insert_tip_anchor
to properly handle arc length and tip length.pointwise_become_partial
withstart_new_path
to avoid distorted geometry.create_tip_with_stroke_width
to computetip_width
usingoriginal_stroke_width
for consistent tip geometry.Test
Code used:
Result
Before
After