Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 67.15% 67.15%
=======================================
Files 485 485
Lines 15563 15563
Branches 1765 1765
=======================================
Hits 10451 10451
Misses 5112 5112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Awesome, thanks @jqnm Some first comments/additions:
|
Collaborator
Author
Everything is done, except the last comment |
Updated the rangeMin_m to 3 m and the beam divergence to 0.001 rad. Also added the rangeMax_m (450 m). All based on the specs from the L2 datasheet
Added maxNOR and rangeMax_m according to Avia data sheet
…on-repetitive scan pattern for Livox Avia in scanners_tls.xml
… scanners_als.xml
We need to specify the pulse frequency per channel. So if the scanner datasheet says 240,000, but we have 6 channel, it must be 40,000.
b468269 to
05f0927
Compare
…ive mode still has to be checked)
Adapt accuracy and beam divergence so they are consistent for the livox mid series
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.