Skip to content

Issue #332 is duplicate of #312; add missing InvalidSeedException handler in ToolsCalcFinalWordDoneView#333

Closed
Copilot wants to merge 2 commits intodevfrom
copilot/fix-issue-332-duplicate
Closed

Issue #332 is duplicate of #312; add missing InvalidSeedException handler in ToolsCalcFinalWordDoneView#333
Copilot wants to merge 2 commits intodevfrom
copilot/fix-issue-332-duplicate

Conversation

Copy link

Copilot AI commented Mar 10, 2026

Description

Issue #332 (System Error on 24-word seed entry) is confirmed as a duplicate of #312 (mnemonic wordlist consistency). The user was running the SeSi-0.8.6+ShSi-B8 image, which predates the fix in 15cc5150.

While auditing all convert_pending_mnemonic_to_pending_seed() call sites, ToolsCalcFinalWordDoneView.run() was the only one missing a try/except InvalidSeedException handler. All other call sites properly catch and redirect to SeedMnemonicInvalidView. Added the missing handler for consistency:

from seedsigner.models.seed import InvalidSeedException
from seedsigner.views.seed_views import SeedMnemonicInvalidView
try:
    self.controller.storage.convert_pending_mnemonic_to_pending_seed(
        wordlist_language_code=self.settings.get_value(SettingsConstants.SETTING__WORDLIST_LANGUAGE),
    )
except InvalidSeedException:
    return Destination(SeedMnemonicInvalidView)

No screenshots — no UI changes; only exception handling added to an existing code path.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

  • I've run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • No, I'm a fool
  • Yes
  • N/A

I have tested this PR on the following platforms/os:


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: 3rdIteration <2230318+3rdIteration@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue 332 marked as duplicate of issue 312 Issue #332 is duplicate of #312; add missing InvalidSeedException handler in ToolsCalcFinalWordDoneView Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants