Update MSRV and fix linter warnings#105
Merged
Conversation
unleashed
force-pushed
the
update-msrv-and-fix-warnings
branch
4 times, most recently
from
c42bc1f to
3ef9764
Compare
Some dependencies don't really work in the minimal versions. Sometimes we may depend on features introduced in a minor upgrade, and some other times the minimum versions don't work with language features we are now using. These versions are the minimum required for the sources to work including tests.
We really had to do some gymnastics to actually be able to compile threescalers with versions prior to 1.65, so let's just accept reality. We are also upgrading reqwest, and using it will significantly bump the MSRV even if we didn't upgrade, so we're also taking the opportunity to use the latest 0.12 series.
unleashed
force-pushed
the
update-msrv-and-fix-warnings
branch
from
3ef9764 to
0bee7a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found out our real MSRV is 1.65, so we are bumping it to that version.
We also do some cleanups as part of fixing warnings in newer clippy and rustc versions. This includes a few small API breakages, but given master already did so, we can go release 0.9 with these.