Skip to content

feat: centralize scheme configuration via runtimeconfig#32

Merged
3scale-robot merged 1 commit intomainfrom
feat/runtimeconfig
Oct 3, 2025
Merged

feat: centralize scheme configuration via runtimeconfig#32
3scale-robot merged 1 commit intomainfrom
feat/runtimeconfig

Conversation

@roivaz
Copy link
Contributor

@roivaz roivaz commented Oct 3, 2025

Introduce a concurrency-safe runtimeconfig package to own the shared runtime scheme, hook reconciler.NewFromManager into it, and update template constructors plus docs/tests to use the unified scheme API.

/kind feature
/priority important-soon
/assign

Introduce a concurrency-safe runtimeconfig package to own the shared
runtime scheme, hook reconciler.NewFromManager into it, and update
template constructors plus docs/tests to use the unified scheme API.
@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels Oct 3, 2025
@3scale-robot 3scale-robot requested review from raelga and slopezz October 3, 2025 14:12
@3scale-robot 3scale-robot added wg/sre Categorizes issue or PR as related to the SRE working group. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/M Requires about a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 3, 2025
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@3scale-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: af6ef6cdb80440905b780cecfa4f8af7a6cfff73

@roivaz
Copy link
Contributor Author

roivaz commented Oct 3, 2025

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2025
@3scale-robot 3scale-robot merged commit d170c4c into main Oct 3, 2025
6 checks passed
@3scale-robot 3scale-robot deleted the feat/runtimeconfig branch October 3, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/M Requires about a day to complete the PR or the issue. wg/sre Categorizes issue or PR as related to the SRE working group.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants