Include controllers/apps in unit test coverage

[urbanikb]

What

Since the make test-unit target is the only target we currently scrape coverage from (due to e2e test being run by prow and not sending data to codecov), it would be good if the unit tests in controllers/app would also run there.

Currently there are no unit tests defined, but there might be in the future PR.

How

• Move the test code that requires envtest out of directory structure for operator code
• Rename e2e test to integration test and add Makefile target

Verification

Checked that makefile targets work as before.
Ran the test-integration test locally against the Fyre cluster, it ran as usual.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.84%. Comparing base (4e62f84) to head (ea2f05e).
⚠️ Report is 27 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
+ Coverage   39.34%   41.84%   +2.49%     
==========================================
  Files         205      203       -2     
  Lines       23363    20859    -2504     
==========================================
- Hits         9193     8729     -464     
+ Misses      13184    11350    -1834     
+ Partials      986      780     -206     

Flag	Coverage Δ
unit	41.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
apis/apps/v1alpha1 (u)	58.55% <ø> (+29.45%)	⬆️
apis/capabilities/v1alpha1 (u)	3.50% <ø> (+1.99%)	⬆️
apis/capabilities/v1beta1 (u)	20.21% <ø> (-1.16%)	⬇️
controllers (i)	9.31% <0.00%> (-0.02%)	⬇️
pkg (u)	61.71% <81.13%> (+0.72%)	⬆️
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tkan145]

As the test is not really e2e, can we have another folder called /test/integration instead? Then add a new entry inside Makefile to run the integration test

[urbanikb]

As the test is not really e2e, can we have another folder called /test/integration instead? Then add a new entry inside Makefile to run the integration test

Just to rephrase what you are asking is to rename e2e to integration, is this correct? There is no "other" e2e test that would be left.

[tkan145]

Yes correct, and we need a new entry in the Makefile for the integration tests, I would also like to keep make test-e2e but pointing to the e2e directory, which will be empty so the test will return early. Once mergerd, I will update prow to run both e2e (current) and integration.