Skip to content

⬆️ upgrade swagger-ui to 5.27.1#4218

Open
josemigallas wants to merge 1 commit intomasterfrom
THREESCALE-12255_swagger_ui_27
Open

⬆️ upgrade swagger-ui to 5.27.1#4218
josemigallas wants to merge 1 commit intomasterfrom
THREESCALE-12255_swagger_ui_27

Conversation

@josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Feb 5, 2026

THREESCALE-12255: Update swagger-ui to 5.27.1

Latest is 5.31 but 5.28 breaks our implementation. While I figure out why, this is the most recent version we can update to.

Verification steps

This module is used in OAS 3 specs in the following pages:

  • 3scale API Documentation /p/admin/api_docs
  • api_docs with apiconfig/services/:service_id/api_docs/:id/preview
  • dev portal docs page /docs

ℹ️ https://github.com/swagger-api/swagger-ui/releases

@qltysh
Copy link

qltysh bot commented Feb 5, 2026

❌ 1 blocking issue (1 total)

Tool Category Rule Count
eslint Lint Unsafe argument of type any assigned to a parameter of type string. 1

@josemigallas josemigallas requested a review from a team February 6, 2026 10:13
@josemigallas josemigallas self-assigned this Feb 6, 2026
Copy link
Contributor

@jlledom jlledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem with 5.28? It's surprising we can upgrade 2 major versions at once but then there's a breaking change in a minor version.

Copy link
Contributor

@jlledom jlledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine for me, I found a small bug. In the request body section for POST and PUT requests, the fields are auto-filled wrongly, I think.

Before:
Image

After:

Image

@mayorova
Copy link
Contributor

mayorova commented Feb 9, 2026

Seems to work fine for me, I found a small bug. In the request body section for POST and PUT requests, the fields are auto-filled wrongly, I think.

That rings a bell... See Notes for reviewer in #3934

@josemigallas
Copy link
Contributor Author

josemigallas commented Feb 9, 2026

What's the problem with 5.28? It's surprising we can upgrade 2 major versions at once but then there's a breaking change in a minor version.

It's TBI (to be investigated). It simply throws an error in the browser console and doesn't render anything.

@github-actions github-actions bot added the Stale label Mar 14, 2026
@3scale 3scale deleted a comment from github-actions bot Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants