THREESCALE-12434: Migrate from protected attributes to strong parameters - Part 3#4255
Open
mayorova wants to merge 4 commits intostrong-params-part2from
Open
THREESCALE-12434: Migrate from protected attributes to strong parameters - Part 3#4255mayorova wants to merge 4 commits intostrong-params-part2from
mayorova wants to merge 4 commits intostrong-params-part2from
Conversation
❌ 7 blocking issues (7 total)
|
3464b1d to
c9f7b0d
Compare
c9f7b0d to
a37003a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is part 3 (final) of the migration from protected attributes to strong parameters. See also:
Protected attributes is an old Rails feature which was deprecated a long time ago. We were using protected_attributes_continued gem to keep it working, but now it's also discontinued and does not support Rails 7+, so it's a blocker for upgrading to Rails 7.2 for us.
This part clears up all the remaining references to protected attributes, and removes the
protected_attributes_continuedgem.Which issue(s) this PR fixes
https://redhat.atlassian.net/browse/THREESCALE-12434
Verification steps
All tests should pass, and all features should work as before.
Special notes for your reviewer: