Skip to content

Grading PR#47

Open
martypdx wants to merge 2 commits into401-Final:devfrom
martypdx:dev
Open

Grading PR#47
martypdx wants to merge 2 commits into401-Final:devfrom
martypdx:dev

Conversation

@martypdx
Copy link

No description provided.

@martypdx
Copy link
Author

Comments and feedback are inline in code. General comments here:

  • Don't let root of project get so cluttered. Put sample data in folders
  • Nice job overall on routing and server organization. Need to work on orchestrating workflows with Promises. Also some of the model logic is in the routes, use static and methods to move that work to model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant