Add 4C documentation link with icon #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaSi5002
force-pushed
the
feature/docs-icon
branch
from
6bd5fa0 to
4ce5c82
Compare
dragos-ana
requested changes
Jun 5, 2025
Collaborator
dragos-ana
left a comment
dragos-ana
left a comment
There was a problem hiding this comment.
Thanks for adding the documentation, it looks nice.
Just my personal taste, but I would rather place 4C icon - 4C documentation tooltip - (some space...) - 4C Webviewer title horizontally. But this is subjective, and not really binding. However, please adapt everything from german to english.
Collaborator
|
Please squash the commits. |
Update src/fourc_webviewer/gui_utils.py Co-authored-by: Dragos Ana <[email protected]> Update src/fourc_webviewer/gui_utils.py Co-authored-by: Dragos Ana <[email protected]> Update src/fourc_webviewer/gui_utils.py Co-authored-by: Dragos Ana <[email protected]> Add docs link with button
LaSi5002
force-pushed
the
feature/docs-icon
branch
from
f2859e2 to
a9b07ad
Compare
dragos-ana
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.