property descriptions (general sections only) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaSi5002
force-pushed
the
feature/property-descriptions
branch
from
bdf3649 to
1780ae8
Compare
c-p-schmidt
reviewed
Jun 10, 2025
Contributor
c-p-schmidt
left a comment
c-p-schmidt
left a comment
There was a problem hiding this comment.
I checked out your branch to see what it looks like.
I really like that the description appears when you hover over an item.
However, you can eliminate the intermediate states by squashing the commits. I also realized that the button to the docu is also not available on your branch, i.e., you could also rebase on the newest main, but this is, of course, not mandatory because there are no conflicts.
dragos-ana
reviewed
Jun 10, 2025
Collaborator
dragos-ana
left a comment
dragos-ana
left a comment
There was a problem hiding this comment.
Nice work! Left a comment in regards to server variables versus state variables.
LaSi5002
force-pushed
the
feature/property-descriptions
branch
from
f5460cf to
fe7485e
Compare
c-p-schmidt
approved these changes
Jun 11, 2025
LaSi5002
force-pushed
the
feature/property-descriptions
branch
2 times, most recently
from
056747f to
7e963ff
Compare
LaSi5002
force-pushed
the
feature/property-descriptions
branch
from
7e963ff to
5ee6f89
Compare
dragos-ana
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only adds descriptions for the general sections and the material section.
The other sections like functions will be streamlined later to fit this approach.