Bugfix: initialize render window only once, fix current material determination #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-p-schmidt
approved these changes
Nov 11, 2025
Contributor
c-p-schmidt
left a comment
c-p-schmidt
left a comment
There was a problem hiding this comment.
Looks good. But the formatting is broken according to the pipeline.
- The render window can only be initialized only once per session in the current setup, otherwise there is no proper binding to the new render window. This can be easily checked by switching to a new input file in the current state of the tool. This commit fixes the underlying issue by only initializing the render window if it was not saved on the server side. - Also, there was a non-existent function used for the determination of the current material. This is fixed as well.
dragos-ana
force-pushed
the
bugfix-render-window-creation
branch
from
7803619 to
47a31b2
Compare
c-p-schmidt
approved these changes
Nov 11, 2025
Contributor
|
The |
Collaborator
Author
|
That's true, thanks! Please remove this yourself in the upcoming PR since this PR is already merged, and the small deletion does not require a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two bugs related to #29:
Interested parties: @LaSi5002, @c-p-schmidt