feat: introduce pytest #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-p-schmidt
approved these changes
May 23, 2025
Contributor
c-p-schmidt
left a comment
c-p-schmidt
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you!
Collaborator
Author
|
@c-p-schmidt @dragos-ana I had to rebase (we'll squash the commits at merge). Could you review and (dis)approve again? |
dragos-ana
reviewed
May 24, 2025
Collaborator
dragos-ana
left a comment
dragos-ana
left a comment
There was a problem hiding this comment.
@gilrrei Thank you for setting up the pytest framework. Left a comment for something that is not clear to me at this point
Collaborator
Author
|
This PR also introduces pytest markers. If you want to run the tests that require a GUI you can call them using |
Contributor
|
@gilrrei There is a conflict in the requirements.txt file. |
dragos-ana
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces pytest. Together with a basic test.
@dragos-ana I took the liberty of moving the defaults from the
run_webserverdirectly to the class. I hope that's fine with you