Fix function evaluation #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the evaluation of functional expression by using numexpr. The previous approach of using eval was unsafe, while safely_parse_string did not work properly. The latter was also removed. - Adapted the requirements files to include numexpr.
dragos-ana
force-pushed
the
fix-function-evaluation
branch
from
c5a82c7 to
5383653
Compare
gilrrei
approved these changes
May 30, 2025
Collaborator
gilrrei
left a comment
gilrrei
left a comment
There was a problem hiding this comment.
Sorry for the late review. Lgtm, thanks fir the update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numexpr. The previous approach of usingevalwas unsafe, whilesafely_parse_stringdid not work properly. The latter was also removed.numexpr.In collaboration with @c-p-schmidt