ASAN: only suppress report on specific memory leaks #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Suppressing only what I have in this PR reveals 1,100 indirect leaks in our code or related to mistakes that we make (test beam3r_line2_genalpha_liegroup_contact_penalty_linpen_twocrossedbeams.4C.yaml-p2). Interestingly, there are no direct leaks. This means that all leaks are caused by reference counting cycles as reported e.g. in #413. |
maxfirmbach
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back when I introduced AddressSanitizer (ASAN) years ago on Gitlab, we had enough to do to fix the serious memory errors. Memory leak reports were always suppressed since then. This PR makes the various suppressions explicit. Draft for now, maybe I can fix a few leaks right away.
Related to #413