Evaluate initial acceleration with full RHS vector #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amgebauer
force-pushed
the
fix-solid-init-acceleration
branch
from
869d1f2 to
6394cd2
Compare
mayrmt
previously approved these changes
Sep 7, 2025
amgebauer
force-pushed
the
fix-solid-init-acceleration
branch
from
6394cd2 to
75a8257
Compare
mayrmt
previously approved these changes
Sep 8, 2025
amgebauer
force-pushed
the
fix-solid-init-acceleration
branch
from
75a8257 to
c92bb99
Compare
mayrmt
approved these changes
Sep 8, 2025
davidrudlstorfer
approved these changes
Sep 8, 2025
mayrmt
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the setup of the new structural framework, we evaluate the RHS to compute the initial accelerations. The vector we created previously was only large enough to accommodate the solid RHS. However, for cardiovascular0D-BCs and Lagrange constraints, this vector was too short to assemble their RHS. In these modules, we had a peculiar check to determine whether to assemble their RHS, which depended on the node numbering at input.
This issue has now been resolved: we create an RHS of the appropriate size and assemble the entire RHS.
I also removed unnecessary pointers on the way.
Related to #733