Skip to content

Add rotational coupling test for beaminteraction with Lagrange Multipliers #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dharinib98 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add rotational coupling test for beaminteraction with Lagrange Multipliers #1501

dharinib98 wants to merge 2 commits into from

Conversation

@dharinib98
Copy link
Contributor

@dharinib98 dharinib98 commented Nov 14, 2025

Description and Context

This PR adds a test checking the implementation of Lagrange Multipliers for beaminteraction problems (#637 ) with rotational coupling enabled.

Related Issues and Pull Requests

#1206

@dharinib98 dharinib98 self-assigned this Nov 14, 2025
@dharinib98 dharinib98 added the type: enhancement A new feature or enhancement to be implemented label Nov 14, 2025
@dharinib98 dharinib98 changed the title Add rotational coupling test with LM Add rotational coupling test for beam interaction with Lagrange Multipliers Nov 14, 2025
@dharinib98 dharinib98 changed the title Add rotational coupling test for beam interaction with Lagrange Multipliers Add rotational coupling test for beaminteraction with Lagrange Multipliers Nov 14, 2025
@dharinib98 dharinib98 force-pushed the add_test_rotational_coupling branch from 2dc7641 to 80bef8d Compare November 14, 2025 14:49
@mayrmt mayrmt mentioned this pull request Nov 14, 2025
Open
3 tasks
@dharinib98 dharinib98 mentioned this pull request Jan 14, 2026
Open
3 tasks
@isteinbrecher isteinbrecher mentioned this pull request Jan 29, 2026
Merged
@dharinib98 dharinib98 force-pushed the add_test_rotational_coupling branch 3 times, most recently from f3c73e4 to 42eb2bb Compare January 30, 2026 10:27
@dharinib98
Copy link
Contributor Author

dharinib98 commented Jan 30, 2026

@isteinbrecher @mayrmt @maxfirmbach With #1691, #1540 and #1660 merged, we can proceed with this. We no longer have relaxed tolerances and slow convergence.

isteinbrecher
isteinbrecher reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@isteinbrecher isteinbrecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dharinib98 looking good, nice to see that the feature already works and only the test case has to be added.

@dharinib98 dharinib98 force-pushed the add_test_rotational_coupling branch from 42eb2bb to e5fd9f5 Compare January 30, 2026 11:55
@dharinib98 dharinib98 force-pushed the add_test_rotational_coupling branch from e5fd9f5 to 8f63946 Compare January 30, 2026 11:58
mayrmt
mayrmt requested changes Jan 30, 2026
View reviewed changes
...upling_mortar_lagrange_saddlepoint_line4_line3_deformation_gradient_3d_cross_section.4C.yaml Outdated
Comment on lines 2 to 3
- "Description: Simulate a beam coupled to a cantilevered solid using Lagrange multipliers with the
saddlepoint formulation."
Copy link
Member

@mayrmt mayrmt Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should include the fact, that this test is responsible for rotation coupling.

@mayrmt
Copy link
Member

mayrmt commented Jan 30, 2026

The test seems to write run time output, though it is not used in the test for testing the output. Or am I misunderstanding this?

@dharinib98
Copy link
Contributor Author

dharinib98 commented Jan 30, 2026

The test seems to write run time output, though it is not used in the test for testing the output. Or am I misunderstanding this?

Yes. We do not test the output. I tried to suppress some runtime output here. Maybe some more can also be switched off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isteinbrecher isteinbrecher isteinbrecher left review comments

@mayrmt mayrmt mayrmt requested changes

@maxfirmbach maxfirmbach Awaiting requested review from maxfirmbach

Requested changes must be addressed to merge this pull request.

Assignees

@dharinib98 dharinib98

Labels

type: enhancement A new feature or enhancement to be implemented

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dharinib98 @mayrmt @isteinbrecher @maxfirmbach