Use consistent way to compute the deformation gradient

src/solid_3D_ele/4C_solid_3D_ele_calc_lib.hpp

@@ -588,28 +588,12 @@ namespace Discret::Elements
       const JacobianMapping<celltype>& jacobian_mapping,
       const ElementNodes<celltype>& element_nodes, const double scale_defgrd = 1.0)
   {
-    Core::LinAlg::Tensor<double, 3, 3> defgrd;
-    if constexpr (celltype == Core::FE::CellType::hex8)
-    {
-      // For some reason, some contact tests with hex8 discretization don't like the computation
-      // of the deformation gradient based on the nodal displacements. They only converge if the
-      // deformation gradient is computed based on the current coordinates. Similarly, there are
-      // ssi and ssti tests with an tet4 discretization that only converge when using the
-      // displacements. Until we found the problem, we compute the deformation gradient based on
-      // the current coordinates (F=(X+u)^T  dN/dX^T) for hex8 and based on the displacement (F=I
-      // + u^T dN/dX^T) for the other celltypes.
-      Core::LinAlg::make_matrix_view(defgrd).multiply_nt(scale_defgrd,
-          element_nodes.current_coordinates,
-          Core::LinAlg::make_matrix_view(jacobian_mapping.N_XYZ));
-    }
-    else
-    {
-      defgrd = Core::LinAlg::get_full(Core::LinAlg::TensorGenerators::identity<double,
-          Core::FE::dim<celltype>, Core::FE::dim<celltype>>);
+    Core::LinAlg::Tensor<double, 3, 3> defgrd =
+        Core::LinAlg::get_full(Core::LinAlg::TensorGenerators::identity<double,
+            Core::FE::dim<celltype>, Core::FE::dim<celltype>>);
 
-      Core::LinAlg::make_matrix_view(defgrd).multiply_nt(scale_defgrd, element_nodes.displacements,
-          Core::LinAlg::make_matrix_view(jacobian_mapping.N_XYZ), scale_defgrd);
-    }
+    Core::LinAlg::make_matrix_view(defgrd).multiply_nt(scale_defgrd, element_nodes.displacements,
+        Core::LinAlg::make_matrix_view(jacobian_mapping.N_XYZ), scale_defgrd);
 
     return defgrd;
   }

tests/input_files/cardiovascular0d_arterialproxdist_structure_direct_genalpha.4C.yaml

@@ -91,7 +91,7 @@ RESULT DESCRIPTION:
       DIS: "structure"
       NODE: 226
       QUANTITY: "dispz"
-      VALUE: 8.0088764
+      VALUE: 8.0082124
       TOLERANCE: 1e-06
 DESIGN SURF DIRICH CONDITIONS:
   - E: 1

tests/input_files/cardiovascular0d_arterialproxdist_structure_direct_genalpha_mor.4C.yaml

@@ -88,7 +88,7 @@ RESULT DESCRIPTION:
       DIS: "structure"
       NODE: 226
       QUANTITY: "dispz"
-      VALUE: 11.76073357
+      VALUE: 11.76097949
       TOLERANCE: 1e-06
 DESIGN SURF DIRICH CONDITIONS:
   - E: 1

tests/input_files/cardiovascular0d_arterialproxdist_structure_direct_genalpha_new_struc.4C.yaml

@@ -98,7 +98,7 @@ RESULT DESCRIPTION:
       DIS: "structure"
       NODE: 226
       QUANTITY: "dispz"
-      VALUE: 8.0088764
+      VALUE: 8.0082124
       TOLERANCE: 1e-06
 DESIGN SURF DIRICH CONDITIONS:
   - E: 1

tests/input_files/cardiovascular0d_syspulcirculation_2chamber_structure_direct_genalpha.4C.yaml

@@ -146,37 +146,37 @@ RESULT DESCRIPTION:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_at_l"
-      VALUE: 0.559884105
+      VALUE: 0.55984112
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_vin_l"
-      VALUE: 3572.215
+      VALUE: 3579.218
       TOLERANCE: 1e-02
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_vout_l"
-      VALUE: -0.873007587
+      VALUE: -0.8730205
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_v_l"
-      VALUE: 0.55631152575
+      VALUE: 0.5562618947
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_ar_sys"
-      VALUE: 9.28639031
+      VALUE: 9.28646698
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_ar_sys"
-      VALUE: 60020.54353557
+      VALUE: 60021.21905
       TOLERANCE: 1e-01
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
@@ -188,61 +188,61 @@ RESULT DESCRIPTION:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_ven_sys"
-      VALUE: 76552.110876
+      VALUE: 76552.67
       TOLERANCE: 1e-01
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_at_r"
-      VALUE: 0.28536038599529967
+      VALUE: 0.28534563
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_vin_r"
-      VALUE: 28909.89
+      VALUE: 29402.63
       TOLERANCE: 1e-01
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_vout_r"
-      VALUE: -0.1890935624
+      VALUE: -0.189146138
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_v_r"
-      VALUE: 0.2564504
+      VALUE: 0.255943006
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_ar_pul"
-      VALUE: 2.1473860428297766
+      VALUE: 2.1474043877
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_ar_pul"
-      VALUE: 30912.234873850
+      VALUE: 30911.1402
       TOLERANCE: 1e-01
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_ven_pul"
-      VALUE: 1.6837022448701402
+      VALUE: 1.6837373
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_ven_pul"
-      VALUE: 74921.268
+      VALUE: 74926.411
       TOLERANCE: 1e-01
   - STRUCTURE:
       DIS: "structure"
       NODE: 226
       QUANTITY: "dispz"
-      VALUE: -0.449860625
+      VALUE: -0.448923267
       TOLERANCE: 1e-06
 DESIGN SURF NEUMANN CONDITIONS:
   - E: 8

tests/input_files/cardiovascular0d_syspulcirculation_2chamber_structure_simple_genalpha.4C.yaml

@@ -158,37 +158,37 @@ RESULT DESCRIPTION:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_at_l"
-      VALUE: 0.5598841
+      VALUE: 0.5598411
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_vin_l"
-      VALUE: 3572.215260
+      VALUE: 3579.2180105
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_vout_l"
-      VALUE: -0.873007587
+      VALUE: -0.873020508
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_v_l"
-      VALUE: 0.556311525756
+      VALUE: 0.5562618947
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_ar_sys"
-      VALUE: 9.2863903
+      VALUE: 9.2864669756
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_ar_sys"
-      VALUE: 60020.567167
+      VALUE: 60021.219047
       TOLERANCE: 1e-05
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
@@ -200,61 +200,61 @@ RESULT DESCRIPTION:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_ven_sys"
-      VALUE: 76552.110999
+      VALUE: 76552.670945
       TOLERANCE: 1e-05
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_at_r"
-      VALUE: 0.28536038599529023
+      VALUE: 0.28534633
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_vin_r"
-      VALUE: 28909.834795
+      VALUE: 29402.627819
       TOLERANCE: 1e-05
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_vout_r"
-      VALUE: -0.1890935624
+      VALUE: -0.189146138
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_v_r"
-      VALUE: 0.256450353
+      VALUE: 0.255943006
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_ar_pul"
-      VALUE: 2.1473860428298606
+      VALUE: 2.147404387685
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_ar_pul"
-      VALUE: 30912.19004
+      VALUE: 30911.14022
       TOLERANCE: 1e-05
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "p_ven_pul"
-      VALUE: 1.683702244870212
+      VALUE: 1.683737284
       TOLERANCE: 1e-06
   - CARDIOVASCULAR0D:
       DIS: "cardiovascular0d"
       SPECIAL: true
       QUANTITY: "q_ven_pul"
-      VALUE: 74921.26821
+      VALUE: 74926.41144
       TOLERANCE: 1e-05
   - STRUCTURE:
       DIS: "structure"
       NODE: 226
       QUANTITY: "dispz"
-      VALUE: -0.4498606
+      VALUE: -0.448923
       TOLERANCE: 1e-06
 DESIGN SURF NEUMANN CONDITIONS:
   - E: 8