[NOX] Inherit matrix-free operators from SparseOperator
#1568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
In order to proceed with removal of the base inheritances of
NOX::Nln::Interface::RequiredBaseandNOX::Nln::Interface::JacobianBasequite substantial modifications are required. This is just one of them and it effectively removesEpetra_Operatoryet from one more place. It is also required for #1524.A temporary wrapper
NOX::Nln::MatrixFree::SparseOperatorWrapperis introduced here. Ultimately, it will be either simplified or completely removed later.While working on this PR, I noticed that the default interface of
Core::LinAlg::SparseOperatoris excessive: most of the methods should be removed. For instance,is_dbc_applied()- it is very specific and is used in a single place of the code.add_other()- it is odd and not used at all.This is just what I identified by a quick look.
Related Issues and Pull Requests
#1524, #1535, #1486