Evaluate BTB penalty parameters by a function #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies evaluation of the beam-to-beam penalty value with respect to a function by time.
knarfnitram
commented
Dec 3, 2025
| for (auto& pair : newbeaminteractionpairs) | ||
| { | ||
| pair->init(beam_contact_params_ptr_, ele_ptrs); | ||
| pair->init(beam_contact_params_ptr_, ele_ptrs, g_state().get_time_n()); |
Contributor
Author
There was a problem hiding this comment.
Here I am not so sure, if we really want to pass the time into the pair, and especially the previous or next time.
| .default_value = -1.0}), | ||
| parameter<int>("BEAMS_BTBPENALTYPARAM_BY_FUNCT", | ||
| {.description = "Penalty parameter for beam-to-beam point contact by function id", | ||
| .default_value = -1}), |
Contributor
There was a problem hiding this comment.
Let's not add a default of -1 anymore. You can also make it a noneable default.
Contributor
There was a problem hiding this comment.
Also - would it make more sense to add a new "subsection" and then you chose if you either have a constant value or a function id?
Like it's done with the input fields. Because the parameter is somehow duplicated as far as I understand?
Comment on lines
96
to
99
| if (btb_point_penalty_param_ > 0.0 and btb_function_id_for_point_penalty > 0.0) | ||
| FOUR_C_THROW( | ||
| "Please specify the beam-to-beam point penalty parameter either with BEAMS_BTBPENALTYPARAM " | ||
| "or BEAMS_BTBPENALTYPARAM_BY_FUNCT. Not both!"); |
Contributor
There was a problem hiding this comment.
If you already verify this during input it would probably make more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Selecting a single value for the beam to beam penalty parameter can be cumbersome, this MR modifies the beam contact to specify the penalty parameters by a function instead of single value from the inputfile.
Hence two new parameters,
BEAMS_BTBPENALTYPARAM_BY_FUNCTandBEAMS_BTBLINEPENALTYPARAM_BY_FUNCTare introduced, which evaluate the parameters within the contact pair at the specified time.Two test cases, one for the line and the other for the point penalty value are provided.
Related Issues and Pull Requests