Skip to content

Enable coupled dof equation condition in 3d #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-frey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable coupled dof equation condition in 3d #1751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/constraint_framework/4C_constraint_framework_input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,9 @@ void Constraints::set_valid_conditions(std::vector<Core::Conditions::ConditionDe
Core::Conditions::PointLinearCoupledEquation, false, Core::Conditions::geometry_type_point);

linear_ce.add_component(parameter<int>("EQUATION", {.description = "EQUATION"}));
Copy link
Contributor

@ischeider ischeider Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also change the description of EQUATION to something more useful? What kind of equation is possible, with which dependencies? See also comment to COEFFICIENT.
If it refers to a function, then shouldn't we redefine the parameter to FUNCT, which is the name that we use in general? Even though it is a breaking change then.

linear_ce.add_component(deprecated_selection<std::string>("ADD", {"dispx", "dispy", "undefined"},
{.description = "degrees of freedom", .default_value = "undefined"}));
linear_ce.add_component(
deprecated_selection<std::string>("ADD", {"dispx", "dispy", "dispz", "undefined"},
Comment on lines 110 to +114
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition definition text right above still describes the coupled DOF equation as being for "2d", but the allowed DOFs now include dispz (3D). Please update the human-readable description so the input schema matches the actual capabilities and doesn't mislead users.

Copilot uses AI. Check for mistakes.
{.description = "degrees of freedom", .default_value = "undefined"}));
Comment on lines +113 to +115
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding dispz changes supported input behavior, but there is no regression test covering a 3D DESIGN POINT COUPLED DOF EQUATION CONDITIONS term with ADD: "dispz". Consider adding a 3D integration test input (similar to tests/input_files/rve3d_periodic_bcs.4C.yaml, but including a PointLinearCoupledEquation section with dispz) and registering it in tests/list_of_tests.cmake (there is already a 2D MPC test: rve2d_periodic_bcs_with_mpcs.4C.yaml).

Copilot uses AI. Check for mistakes.
linear_ce.add_component(parameter<double>("COEFFICIENT"));
Copy link
Contributor

@ischeider ischeider Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coefficient does not have a description at all. Since there is also EQUATION available, I don't know what an additional coefficient could do (maybe I fully misunderstand the parameters). If it is a factor added to the function/equation, I recommend to make it optional with 1 as a default value.


condlist.push_back(linear_ce);
Expand Down
4 changes: 4 additions & 0 deletions src/constraint_framework/4C_constraint_framework_submodelevaluator_mpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,10 @@ int Constraints::SubmodelEvaluator::RveMultiPointConstraintManager::build_linear
{
dofPos = 1;
}
else if (dofStr == "dispz")
{
dofPos = 2;
}
Comment on lines +635 to +638
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dispz is now mapped to dofPos = 2, but there is no guard that the current problem/RVE actually has a third displacement DOF. In a 2D setup, this will likely index discret_ptr_->dof(node)[2] out of range. Add a dimension/DOF-count check (e.g., based on rve_dim_ or discret_ptr_->dof(node).size()) and throw a clear error when dispz is used in 2D.

Copilot uses AI. Check for mistakes.
else
{
FOUR_C_THROW(
Expand Down
Loading