-
Notifications
You must be signed in to change notification settings - Fork 3
chore: update dependencies #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| { | ||
| "name": "@4c/graphql-node-resource", | ||
| "version": "5.1.0", | ||
| "packageManager": "[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using this and corepack to ensure the proper yarn version is used. This is a typical setup, I believe. Open to suggestions, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates project dependencies to their latest versions, including major version bumps for testing frameworks (Jest 27→30), Node.js tooling (TypeScript 4.7→5.9), and build tools. The update also modernizes CI/CD workflows by upgrading GitHub Actions and replacing the deprecated codecov CLI with the official Codecov action.
Key Changes:
- Updated core dependencies including TypeScript, Jest, ESLint plugins, and Node.js types to current versions
- Migrated from Yarn v1 to v4 with explicit package manager specification
- Updated Node.js requirement from v12+ to v20+ and CI from Node 14 to Node 22
Reviewed changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated all dependencies to latest versions, added Yarn 4 package manager specification, bumped Node requirement to v20+ |
| .yarnrc.yml | Added Yarn configuration to use node-modules linker |
| .github/workflows/main.yml | Upgraded GitHub Actions versions, updated Node to 22.x, replaced codecov CLI with Codecov action |
| .eslintrc | Added TypeScript ESLint rule to allow empty constructors |
| test/fetch.test.ts | Refactored assertion to use optional chaining for safer property access |
| test/PaginatedHttpResource.test.ts | Changed toThrowError to toThrow and reordered import statements |
| test/NodeType.test.ts | Reordered import statements for consistency |
| test/HttpResource.test.ts | Reordered import statements for consistency |
| src/types/createResolve.ts | Added type constraint to TSource parameter and imported Obj type |
| src/types/ResourceCache.ts | Reordered import statements for consistency |
| src/types/NodeType.ts | Reformatted generic type parameters across multiple lines |
| src/resources/PaginatedHttpResource.ts | Reordered import statements for consistency |
| src/resources/HttpResource.ts | Reordered import statements for consistency |
| src/api/HttpError.ts | Removed unused error variable in catch block |
| src/api/HttpApi.ts | Fixed comment formatting to use proper JSDoc style and reordered imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@types/jest": "^27.5.2", | ||
| "@typescript-eslint/eslint-plugin": "^5.33.1", | ||
| "@typescript-eslint/parser": "^5.33.1", | ||
| "codecov": "^3.8.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use codecov's GHA (https://github.com/codecov/codecov-action) instead
package.json
Outdated
| "eslint-config-prettier": "^8.5.0", | ||
| "eslint-plugin-import": "^2.26.0", | ||
| "eslint-plugin-jest": "^25.7.0", | ||
| "eslint-plugin-prettier": "^4.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed since @4c/cli (via the pedantic package's lint command) does all linting
| "no-empty-function": "off", | ||
| "@typescript-eslint/no-empty-function": [ | ||
| "error", | ||
| { | ||
| "allow": ["constructors"] | ||
| } | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a typical config to allow abstract class constructor definitions, I believe
| @@ -1,5 +1,4 @@ | |||
| { | |||
| "plugins": ["prettier"], | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed to fully defer to 4c cli's pedantic library for linting/formatting
Updates various dependencies
Some technically unrelated changes were included due to the staleness of this repo--GHA dependencies, codecov tooling, etc.