Event operations expansion #8117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the ability to target events using their `aiGeneratedEventId` in addition to their path. This allows for more robust event manipulation, especially when dealing with dynamically generated events.
The changes include:
- A new helper function `findEventPathByAiGeneratedEventId` to recursively search for events by their AI ID.
- Modifications to `applyEventsChanges` to attempt finding events by AI ID if path parsing fails.
- Addition of new operation types to handle various event replacement and insertion scenarios, such as:
- `replaceKeepSubEvents`: Replaces an event while preserving its sub-events.
- `insertActionsConditionsAtEnd` and `insertActionsConditionsAtStart`: Inserts actions and conditions at the beginning or end of an event.
- `replaceAllActions` and `replaceAllConditions`: Replaces all actions or conditions of an event.
- Corresponding updates to the test suite (`ApplyEventsChanges.spec.js`) to cover these new functionalities and scenarios.
Co-authored-by: florian <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: florian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains changes generated by a Cursor Cloud Agent