Open
Conversation
added 12 commits
April 17, 2022 10:41
Contributor
Contributor
added 2 commits
May 11, 2022 15:49
Codecov ReportBase: 75.60% // Head: 75.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
============================================
+ Coverage 75.60% 75.86% +0.25%
+ Complexity 392 354 -38
============================================
Files 644 619 -25
Lines 121346 117998 -3348
Branches 1060 1039 -21
============================================
- Hits 91748 89523 -2225
+ Misses 29361 28264 -1097
+ Partials 237 211 -26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
|
check if there is ut to check: after gc, the data is actually deleted |
6188861 to
cafba7a
Compare
…_disk_status_from_main
Collaborator
|
@Leowner could you update the code to resolve the conflict? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SchedGC, GetRecordPkCnt and GetRecordIdxCnt in disktable