Skip to content

Conversation

@xenoy
Copy link
Contributor

@xenoy xenoy commented Oct 27, 2025

Description

Array custom fields were annotated falsy. Instead of the whole string there was only the first letter per array item. This is fixed by removing the type casting. It still works for different field types.

Checklist

The following checklist should help us to stick to our "definition of done":

  • Proposed changes include tests.
  • Good error handling with useful messages
  • Changelog added
  • Django migration files have a meaningful name (not 0000_auto_xyz.py nor 0000_alter_xy_model).
  • Strings are set and translation catalogs have been updated (i18n-scan or i18n-update) and translations made.
  • Readme has been updated if changes interfere with the setup process.

@xenoy xenoy requested a review from a team October 27, 2025 14:18
Copy link
Member

@all4manu all4manu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenoy xenoy force-pushed the nlo/fix-array-field-bug branch from 910a233 to 20c77d6 Compare October 27, 2025 14:22
@xenoy xenoy merged commit 6e9202a into master Oct 27, 2025
1 check passed
@xenoy xenoy deleted the nlo/fix-array-field-bug branch October 27, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants