Skip to content

Conversation

@Acrop146
Copy link
Member

PR-Description: should contain all the information necessary for an outsider to understand the change without looking at the code or the issue!

  • Why the change is necessary
  • What the goal of the change is
  • How change is achieved (e.g. design decisions)
  • The author should advertise and sell the change in the PR body

Screenshot: whenever useful, but only as a visual aid.

Definition of Done: https://4teamwork.atlassian.net/wiki/spaces/CHX4TW/pages/917562/

For [TI-XXXX]

Checklist

Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.

  • Changelog entry
  • Link to issue (Jira or GitHub) and backlink in issue (Jira)

Only applicable should be left and checked.

  • Upgrade-Steps:
    • SQL Operations do not use imported model (see docs)
    • Make it deferrable if possible
    • Execute as much as possible conditionally
    • DB-Schema migration
      • All changes on a model (columns, etc) are included in a DB-schema migration.
      • Constraint names are shorter than 30 characters (Oracle)
  • API change:
    • Documentation is updated
    • API Changelog entry (see guide)
    • If breaking:
      • api-change label added
      • #delivery channel notified about breaking change
      • Scrum master is informed
  • Bug fixed:
    • Resolved any Sentry issues caused by this bug
  • New functionality:
    • for document also works for mail
    • for task also works for forwarding
  • Further improvements needed:
    • Create follow-up stories and link them in the PR and Jira issue
  • Change could impact client installations, client policies need to be adapted
  • New translations
    • All msg-strings are unicode
  • Change in schema definition:
    • If missing_value is specified, then default has to be set to the same value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants