nightly-pull-requests: run PRs sequentially #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-alexander-popel
force-pushed
the
main
branch
3 times, most recently
from
782c18c to
232c622
Compare
pi-alexander-popel
force-pushed
the
main
branch
from
c175f54 to
0c517e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both prevents race conditions when PRs are merged and sometimes allows fixes to merge before other PRs (like package or submodule updates) that depend on those fixes to merge successfully. This is quite random though and depends on GitHub API's ordering of the PRs. We can stabilize the ordering (sort from lowest to highest numbers or the other way around), but:
Meaning we can't always guess the best order, so it'll remain random for now. Until we decide on a better idea.
This will increase the total amount of time the CI runs if there's more than one PR but not always. Some jobs right now get throttled (especially macOS ones) and wait a long time for runner availability. Sometimes the runner becomes available only when other PR's jobs finish, which means they de-facto run in sequence already.