fixed issue #14 : Improve handling of jobs being deleted #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hello @EHJ-52n, |
EHJ-52n
requested changes
Dec 8, 2025
Member
There was a problem hiding this comment.
Please move your new if out of the existing one. I think, having it before line 168 is better.
What do you think?
Member
There was a problem hiding this comment.
It seems to me, that your test should be located in the test_finalizer.py.
This might highlight the case, that your test is not doing anything different from the already existing test test_handle_job_ended_event_does_not_fail_if_no_pod_found_for_job. So, please elaborate, why this test is required and how your new behaviour is tested with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what was happening
When a K8s job is deleted, its pods are often deleted as well. The finaliser was trying to find the pods for the job, failing (because they were already gone), and then logging an ERROR.
changes i made
I updated the logic to check if the job itself is marked for deletion (deletion_timestamp is set). If so, it now correctly interprets the missing Pods as "expected behaviour" during cleanup and logs a DEBUG message instead of an ERROR.
this PR resolves issue #14