feat(api): add feats endpoint and controller with tests #734
+335
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This is the first time I've added to this repo. I started with something small. I went to every spot that had 2024 skills files and added feats. It looks like the skills files were taken straight from 2014 skills, so I did the same with feats. I also updated all references to 2014 to 2024. Please let me know if I am doing this right. Let me know if I should be doing something better.
How was it tested?
I ran
npm run test:unit. All tests passed. I then rannpm run test:integration:local. 5 of the 200+ tests failed. All 5 of them were tests trying to get data from /api/2024/feats (await request(app).get('/api/2024/feats')). I assume because they havent been added yet. I'm not sure.Is there a Github issue this is resolving?
No
Was any impacted documentation updated to reflect this change?
I have absolutely no idea. I'm not sure where to even look. I would guess not.
Here's a fun image for your troubles