refactor(provider): use go-keyring for cross-platform credential storage#34
Merged
priyanshujain merged 12 commits intomasterfrom Mar 9, 2026
Merged
refactor(provider): use go-keyring for cross-platform credential storage#34priyanshujain merged 12 commits intomasterfrom
priyanshujain merged 12 commits intomasterfrom
Conversation
Replace hand-rolled macOS Keychain calls and plain-file-only storage on Linux/Windows with zalando/go-keyring. The library uses native credential stores (Keychain, Secret Service, WinCred) on all three platforms. On headless/Docker environments where no keyring daemon is available, we fall back to the existing ~/.obk/secrets/ file store.
…al/StoreCredential
Drop the silent file-based fallback (~/.obk/secrets/) from credential storage. Errors from the OS keyring are now propagated directly. Headless/CI environments should use environment variables instead, which ResolveAPIKey already supports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zalando/go-keyringfor cross-platform credential storageANTHROPIC_API_KEY, etc.) via the existingResolveAPIKeyenv var pathKeychainLoad/KeychainStoretoLoadCredential/StoreCredential(platform-neutral naming)CGO_ENABLED=0for all targetsTest plan
go test ./provider/— all 38 tests pass