Fix race condition in ScopeWaiter consent flow#91
Merged
priyanshujain merged 1 commit intomasterfrom Mar 18, 2026
Merged
Conversation
Signal could fire before Wait registered the pending state, causing the test (and production consent flow) to hang. Split Wait into Register + Await so the state is registered before the auth link is sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScopeWaiterwhereSignalcould fire beforeWaitregistered the pending state, causing the consent flow to hangWaitintoRegister+Awaitso the state is registered before the auth link is sent viaNotifyLinkTestGWSExecute_MissingScopeSignaledfailures in CITest plan
TestGWSExecute_MissingScopeSignaledpasses 10/10 with-count=10TestScopeWaiter_*tests passagent/toolstest suite passesgo build ./...passes