refactor: move internal services out of source/ into service/#95
Merged
priyanshujain merged 8 commits intomasterfrom Mar 18, 2026
Merged
refactor: move internal services out of source/ into service/#95priyanshujain merged 8 commits intomasterfrom
priyanshujain merged 8 commits intomasterfrom
Conversation
History is no longer registered in the source registry after the move to service/. The New(), Name(), and Status() methods had zero callers. This also removes the stale service → source import dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source/(and top-levelmemory/) into a newservice/directory, sosource/only contains external service integrations andservice/contains internal data stores & system servicessource/usage→service/usage,source/scheduler→service/scheduler,source/history→service/history,source/contacts→service/contacts,memory/→service/memory/status.goto handle history as a direct DB query (like contacts) instead of via the source registryStructure after
Test plan
go build ./...passesgo vet ./...passesgo test ./...— full suite passessource/contacts,source/history,source/scheduler,source/usage, or top-levelmemoryimports remain