fix(tools): use production timeout for agent integration tests#99
Merged
priyanshujain merged 1 commit intomasterfrom Mar 18, 2026
Merged
fix(tools): use production timeout for agent integration tests#99priyanshujain merged 1 commit intomasterfrom
priyanshujain merged 1 commit intomasterfrom
Conversation
Agent runner/stream tests used a 30s timeout while production uses 5 minutes (defaultDelegateTimeout). The tight timeout caused flaky failures when gemini CLI had a cold start (~31s) or when running alongside the full test suite. These are correctness tests, not performance tests — match the production timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultDelegateTimeout(5 minutes) — these are background delegation tasks, not latency-sensitive operationsChanged all 6 real agent tests to use
defaultDelegateTimeoutinstead of30*time.Second. The Go test framework's own timeout (-timeoutflag, default 10min) is the real safety net against hangs.Test plan
TestAgentRunner_RealGeminipasses (12s)TestStreamRunner_RealGeminipasses (10s)go build ./agent/tools/...clean