Open
Conversation
Contributor
|
Bq27220的代码是不是放到公共目录让后续的板子也可以复用比较好? |
Author
我之前看仓库整体的代码还没有人添加这个代码，而且小智有的也使用了不同的芯片，所以我想就不引入单独的包了，这样根据板子隔离也可以最小改动。 后面如果同类型的板子都使用了这个我觉得再统一调整也可以。 @78 虾哥怎么说 |
Owner
|
只有一个板子在就用放在board目录下，如果多个板子在用可以放在common，如果方便其他项目使用，应该做成component。 |
Author
我看目前就我一个在用，能够先合并不，后面要是有需要，我可以再重构一下。 |
Author
|
请问现在是不接受新板子兼容的pr吗 我看这个pr都没人处理了 |
Contributor
This branch has conflicts that must be resolved |
Author
刚才处理了冲突，并本地编译了代码进行了测试。 |
Author
|
@KingingWang 解决了冲突，有时间合并吗？ |
Contributor
额,我合并不了,要让虾哥. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一个基于立创实战派S3拓展的小智聊天盒子，主要是为实战派添加了电源管理模块，和重新设计了外壳，以及添加了Bq27220电源管理的代码，后期可以进一步拓展功能。