fix: show only running containers in force-delete prompt#1987
Open
xz-dev wants to merge 1 commit into89luca89:mainfrom
Open
fix: show only running containers in force-delete prompt#1987xz-dev wants to merge 1 commit into89luca89:mainfrom
xz-dev wants to merge 1 commit into89luca89:mainfrom
Conversation
Previously, when deleting multiple containers with `distrobox-rm`, if any container was running, the prompt incorrectly showed the entire container list instead of just the running containers. This fix: - Collects all running container names first - Shows only running containers in the force-delete prompt - Asks once for all running containers (preserving original behavior) - If user refuses, continues without force flag (running containers will fail) - Exits on invalid input instead of continuing with deletion Signed-off-by: xz-dev <xiangzhedev@gmail.com>
xz-dev
force-pushed
the
fix/rm-running-container-per-container-prompt
branch
from
31bf9b8 to
62d21d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when deleting multiple containers with
distrobox-rm, if any container was running, the prompt incorrectly showed the entire container list instead of just the running containers.This fix: