-
Notifications
You must be signed in to change notification settings - Fork 33
Update dependencies, Github achtions and dependabot strategy #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
refactor(): update actions and packages
refactor(): set nodejs version to current lts version
refactor(): update packages
|
Thanks @mahula and sorry for the late reply. I'll have a look at it on the weekend but at a first glance I think this can be incorporated right away into the next version |
8BitJonny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to check whether all commit hashes of the actions match or not, if the first hash doesn't match.
So thanks for your submission, but I'll do it myself, since I also don't want to change the dependabot config like you proposed
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/checkout@85e6279cec87321a52edac9c87bce653a07cf6c2 # v4.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not true?
v4.2.2 has the hash 11bd71901bbe5b1630ceea73d27597364c9af683
actions/checkout@11bd719
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No,
what the comment at the line's end represents is the most current release version of the used action, while in the workflow the latest commit has is used.
Why did you close the whole PR, @8BitJonny ?
The commit hashes were just one of several changes to the action.
Proposed changes
Pinning Github actions is one measure against supply-chain attacks, see https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash
Types of changes
What types of changes does your code introduce ?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...