CHAL-48 #update Added wiki Home page#73
Conversation
dvorakjt
left a comment
There was a problem hiding this comment.
Hi Phillip,
Good news--I verified that the Github Actions workflow works as expected. However, there are a lot of files included with this PR that I do not wish to merge into the main 8by8 repo.
The only files that should be added by this PR are:
.github/workflows/publish-to-wiki.yml
wiki/Home.md
Please remove all other new files. Please do not add anything to the .gitignore and please remove all files that you have previously added to the .gitignore. The gitignore must not become a mechanism for developers to use to prevent their own personal scratch or temporary files from making it to Github, as this will muddy the intent of the document for other developers in the future.
Once you have removed these files and made a commit, you can create a temporary directory for files you need to work on this task but don't want to commit to the main repo. When you run your git add command, you can exclude this directory by prefixing it with a colon and a caret. Something like this:
git add . :^phillips-personal-temp-directory
I also noticed that you have two copies of Home.md. Please keep the one in the wiki folder and ensure that this one contains the last revision that you wish to commit.
Thanks in advance for these changes!
There was a problem hiding this comment.
Hi Phillip,
This is getting better, good job!
A few points:
- I don't think we want to delete the style guide and contributing files just yet. Let's wait until these have been incorporated into the wiki.
- Could you please format the both files a bit? When the markdown is rendered, it will look fine as it is, but looking at the raw code, I would appreciate 1 line of vertical space before and after headings (except the very first heading, which of course only needs an empty line after it). Also, I would remove extra new lines at the end.
- Could you please rename "How to setup your local development environment" to simply "Getting Started" ?
- In "Getting Started," there are a few things that need clarification:
- Running
npm installinstalls all dependencies, not just Next.js. - VSCode offers several advantages for working with TypeScript, including intellisense, type-checking, and easy refactoring. These features provide immediate feedback when developers introduce errors and make it easy to refactor code for accuracy and clarity. We have had issues with developers using other editors: type-errors were not caught and had to be addressed at the PR review stage when they could have been noticed sooner and fixed before a second set of eyes ever took a look at the code. Therefore, it would be nice to mention these advantages so as to steer developers towards VSCode. Another option that offers similar features is WebStorm from JetBrains. These are the two code editors/IDEs that I can recommend.
- When devs clone the project, the package.json is cloned with it. This file already contains all of the commands necessary to run the project, so there is no need to edit it unless a developer is introducing a new feature. Therefore, step 4 can be removed.
- Keep in mind, not all devs will be using Windows. I would be less specific about how to install Docker, and instead direct them to Docker's own documentation, saying something like "refer to the Docker installation instructions for your operating system."
- Running
- There are other requirements besides Docker and Node. We also need Python 3 for the end-to-end tests.
- A .env file must be created, following the .env.example file.
Keep up the great work, this is much better already!
made requested changes from PR 8by8-org#73
added details specified in PR 8by8-org#73
Added a break to Line 6 and added a few links to the bottom of the page
Added table of contents
Rearranged table of contents, external links
dvorakjt
left a comment
There was a problem hiding this comment.
Looks good! Just get your fork up to date with the upstream repo and we can merge
* CHAL-48 #update Added wiki Home page (#73) * Welcome file.md created from https://stackedit.io/ * How to set up your development environment.md created from https://stackedit.io/ * Common variables.md created from https://stackedit.io/ * Home.md created from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Home.md updated from https://stackedit.io/ * Added Main Page to wiki. * Added development environment setup * Delete CONTRIBUTING.md * Delete Common variables.md * Delete Home.md * Delete How to set up your development environment.md * Delete STYLE_GUIDE.md * Delete doc_base.txt * Delete Welcome file.md * Update Home.md made requested changes from PR #73 * Updated and renamed file added details specified in PR #73 * Update Getting Started.md * Added Links and other change specified Added a break to Line 6 and added a few links to the bottom of the page * Update Home.md Added table of contents * Update Home.md Rearranged table of contents, external links * Changed Getting Started.md file for updated version provided * Deleted old Getting Started file * CHAL-99 #done Upgrade Next.js Version (#77) * upgraded next.js, executed npm audit fix, added react-confetti, supressed irrelevant warnings in test environment * upgraded jest version, fixed failing tests * removed dependency on node 18 from github actions test workflow, restored test coverage to 100% * removed lockfile and reinstalled packages * regenerated lockfile * diagnosing breaking tests in CI * updated node version to latest in test workflow * attempting to resolve failure of tests in ci environment * testing without overrides * attempting to resolve glob issue --------- Co-authored-by: Phillip D <89946282+CaptainExtremis@users.noreply.github.com>
Checklist
Overview
Test Plan
Follow ups
N/A